search

yapplabs / ember-wormhole

Render a child view somewhere else in the DOM.
MIT License
284 stars 68 forks source link

Source Code for Demo? #78

Closed graham-sportsmgmt closed 7 years ago

graham-sportsmgmt commented 7 years ago

Excellent demo, where can we find the source code for it?

lukemelia commented 7 years ago

It can be found in this addon's dummy app: https://github.com/yapplabs/ember-wormhole/tree/master/tests/dummy

graham-sportsmgmt commented 7 years ago

Should that link not be included right underneath the link to the demo itself?

Thanks for the quick reply.

lukemelia commented 7 years ago

Great idea @graham-sportsmgmt! Want to open a PR?

graham-sportsmgmt commented 7 years ago

I'm new to this GitHub thing. I'll try to figure out what you just said and do it though :smile:

lukemelia commented 7 years ago

@graham-sportsmgmt Great, thanks. This is the perfect kind of thing for your first PR!

graham-sportsmgmt commented 7 years ago

Which branch should I use for this? Is it possible to have a documentation branch created?

lukemelia commented 7 years ago

@graham-sportsmgmt you can create a branch off of master in order to use for the PR. An example name could be "doc-add-link-to-readme"

graham-sportsmgmt commented 7 years ago

GitHub wasn't letting me create a branch, but it created one automatically as I saved the edits to readme.md. PR generated, thanks for your guidance on this!