search

yapplabs / ember-wormhole

Render a child view somewhere else in the DOM.
MIT License
284 stars 68 forks source link

Fix getDOM for Ember 2.6/2.7 in integration tests #95

Closed simonihmig closed 7 years ago

simonihmig commented 7 years ago

This addresses #77. The exception mentioned there came up in integration tests. As there were no integration tests here, this was not catched. Added a simple one, and indeed that was failing for Ember 2.6/2.7 with the mentioned exception!

The change here reverts the getDOM function to use the same code that was used in 0.4.1 (the last working version that was not affected by #77) for pre Glimmer2 versions of Ember, while using the newer code path introduced in 0.5.x for Glimmer2 apps (using the -document service).

This PR includes #94, so merge that first!

lukemelia commented 7 years ago

OK, @simonihmig #94 is merged. This is ready for a rebase. Thanks!

simonihmig commented 7 years ago

Ok, finally got the rebase right! 😬

lukemelia commented 7 years ago

Thanks for your work @simonihmig. Published as 0.5.2

simonihmig commented 7 years ago

@lukemelia great, thanks!