search

yapplabs / ember-wormhole

Render a child view somewhere else in the DOM.
MIT License
284 stars 68 forks source link

Add FastBoot tests #99

Closed simonihmig closed 7 years ago

simonihmig commented 7 years ago

Adds FastBoot tests. One with renderInPlace which is passing, and one normal one which is failing due to #86. #96 will hopefully fix the failing test...

krisselden commented 7 years ago

@simonihmig I merge #96 can you rebase?

simonihmig commented 7 years ago

@krisselden did that. Still a failing test, will investigate...

krisselden commented 7 years ago

thank you

simonihmig commented 7 years ago

Stupid me, was just a copy paste error in tests... 🙄

Passing locally now, Travis will hopefully confirm...

simonihmig commented 7 years ago

Travis is good to us! 🎉

sandydoo commented 7 years ago

🎉 Awesome! Thanks @simonihmig and @krisselden for getting this done!

simonihmig commented 7 years ago

No Problem! @krisselden is this good to be merged?