Nullability annotations on YapDatabaseCloudKitRecordHandler blocks

yapstudios / YapDatabase

YapDB is a collection/key/value store with a plugin architecture. It's built atop sqlite, for Swift & objective-c developers.

Other

3.35k stars 365 forks source link

Nullability annotations on YapDatabaseCloudKitRecordHandler blocks #364

Open gardnermj opened 7 years ago

gardnermj commented 7 years ago

I believe the record handler type signatures in Extensions/CloudKit/YapDatabaseExtensionTypes.h (YapDatabaseCloudKitRecordWithKeyBlock, etc) have the wrong nullability annotations, which is breaking things for Swift 3 projects.

See: https://lists.swift.org/pipermail/swift-users/Week-of-Mon-20160919/003342.html

robbiehanson commented 7 years ago

What is the correct nullability annotation ?

gardnermj commented 7 years ago

I'm no ObjC expert, but based on what Jordan wrote I think they just need to be reversed, i.e. to CKRecord *_Nullable *_Nonnull inOutRecordPtr.