yaptide / ui

Yet Another Particle Transport IDE - frontend
https://yaptide.github.io/web_dev/
GNU General Public License v3.0
9 stars 4 forks source link

Improve logging button #1416

Closed grzanka closed 6 months ago

grzanka commented 10 months ago

Whole row should be clickable, not only icon:

image

matuszsmig commented 7 months ago

@grzanka how should log in/log out button look like when user is logged? There is no information about logging out until we hover on this button Zrzut ekranu 2024-03-05 233338

grzanka commented 7 months ago

@grzanka how should log in/log out button look like when user is logged? There is no information about logging out until we hover on this button Zrzut ekranu 2024-03-05 233338

I would remove the username: replace "admin" with "Log out admin" text and use different icon.

matuszsmig commented 7 months ago

Right now looks like this:

Image

Which icon should I use? @grzanka

matuszsmig commented 6 months ago

@grzanka I have devided log out message into two lines:

In case of too long nickname we have two solutions: -Behaves normal way if text doesn't fit it not appear image -We may use text-overflow: ellipsis; and it will wrap into "sometex..." image

Which one solution is better?

grzanka commented 6 months ago

Second one is better

matuszsmig commented 6 months ago

@grzanka https://github.com/yaptide/ui/pull/1518 is ready for Code Review and then for Merge