yapxuanxuan / pe

0 stars 0 forks source link

Does not detect duplicate name (case-insensitive) #2

Open yapxuanxuan opened 6 months ago

yapxuanxuan commented 6 months ago

Steps to Reproduce:

  1. add a contact (e.g add n/James Ho s/A2222444X e/jamesho@example.com h/@hohoho)
  2. try to add another contact with different student id, email and handle, with the same name but different case (e.g add n/james ho s/A2222333X e/jameshohoho@example.com h/@jamesho)

Expected:

Actual:

image.png

Should not allow for duplicate names, names should be case-insensitive as they are case-insensitive in real life.

nus-pe-script commented 6 months ago

Team's Response

It is very possible for 2 people with the same name, it is specified clearly in the UG that names are not unique.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Same name

image.png

The 7th person is "Tests" and the 8th person is "tests" but they display as a same name. This case should be avoided.


[original: nus-cs2103-AY2324S2/pe-interim#5231] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

It is very possible for 2 people with the same name, it is specified clearly in the UG that names are not unique.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** ![image.png](https://raw.githubusercontent.com/yapxuanxuan/pe/main/files/c096535b-338d-4730-b4f1-4ec8ef2b1e81.png) As shown in the course website, duplicate detection is not trivial. While it is mentioned in the UG that contact names are not unique, this can cause issues for the user, such as them adding a duplicate contact accidentally, which should be avoided.
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** At best, severity Low, but this is not a cosmetic issue and should not be assigned as veryLow.