search

yapzhenyie / GadgetsMenu

Feature-rich cosmetics plugin that provide players with the most powerful features.
http://bit.ly/GadgetsMenu
66 stars 24 forks source link

Mystery box broadcast still appearing server-wide for vanished users #857

Closed baailey closed 2 years ago

baailey commented 3 years ago

Describe the bug Users in vanish are still receiving mystery boxes even after this issue was supposedly fixed.

To Reproduce Steps to reproduce the behavior:

  1. Go vanish (using PremiumVanish 2.6.15)
  2. Find a mystery box

Expected behavior As described in this screenshot.

Further Information (please complete the following information):

Screenshots https://gyazo.com/714dfb8d1106ffce36aa6f3fa9d1bb19 (taken 20 minutes ago) https://i.imgur.com/5etAKCh.png (this was taken last month)

yapzhenyie commented 3 years ago

May I know is both players able to see each other?

baailey commented 3 years ago

kira11621 and crackerjack27 can see each other, but Han_Chloe who reacted to crackerjack27 finding a mystery box cannot see anyone.

Additionally, I have done my own testing to see if the issue was due to being able to see the vanished user, but after ample testing I deemed that was not the case and it was simply a bug that anyone and everyone could see the broadcast.

baailey commented 3 years ago

This is still an issue if not aware.

baailey commented 2 years ago

Unsure if this issue is being looked into, or if you're able to implement a fix at all, but the easiest and quickest solution (if this is a tricky situation) is to implement a permission for actually receiving a mystery box. The vanish plugin I'm using supports running commands when the user vanishes and unvanishes, so personally I can have it set and unset the permission when they do either. LuckPerms also supports adding context to a permission, so players can have the permission work, or not work, if they're detected as vanish. Just an idea!

sannielollie commented 2 years ago

Having the same issue too, still waiting for a fix. As a temp solution i have hidden the messages for finding a mysterybox completely (except for getting notified if you find a box yourself)

yapzhenyie commented 2 years ago

Thank you for reporting this issue, it will be fixed in the next update.