yaq-project / yaq-python

Repository for yaq core python packages.
https://yaq.fyi
GNU Lesser General Public License v3.0
5 stars 5 forks source link

DO NOT MERGE hack logging into yaqc socket #33

Closed untzag closed 1 year ago

untzag commented 1 year ago

@ksunden comments would be appreciated

ksunden commented 1 year ago

Other than that, I would just actually create a logger, but set the level so that none of the messages will go through and set the level in startup.py. That avoids any need for global or nonsense that happens when overwriting that variable after it has already been imported

ksunden commented 1 year ago

The other thing I could possibly suggest if we wanted to do a bit less logging to avoid shifting probabilities around, would be to simply log when "remaining" is above like 64....

Really the only times this is usually the case in normal operation are numpy arrays and attune instruments....

But if my suspicions are correct and this is a timing thing related to strings being cut off, I actually suspect that it might be happening more than we think, we just don't notice because the timing curves are self correcting for our implementation in many instances.