yaq-project / yaq-python

Repository for yaq core python packages.
https://yaq.fyi
GNU Lesser General Public License v3.0
5 stars 5 forks source link

Modified placeholder functions and text for has_transformed_position #36

Closed kameyer226 closed 1 year ago

untzag commented 1 year ago

Thanks @kameyer226, I've been using the term "overload" wrong this whole time. Looks like override is the correct term when the method is redefined through inheritance and the function signature remains unchanged.

ksunden commented 1 year ago

I am actually quite strongly against the "multiply by 1.000" here...

I do not think it actually is pedagogically helpful

untzag commented 1 year ago

Since there is some debate, I'm going to hop on and remove the multiplication / reassigning variable names piece from this PR.

@kameyer226 you can reopen the multiplication code in a separate PR if you wish to, we can discuss it there on its own merits.

As a thought, perhaps you could contribute some examples to the YEP instead of changing the code? That might be a more productive way to give new users clues about how to use this trait.

I'll merge the docs changes now. Thanks for the PR.