search

yaq-project / yaqd-attune

MIT License
0 stars 2 forks source link

Rename stage as a dependent name #3

Closed ddkohler closed 2 years ago

ddkohler commented 2 years ago

https://gitlab.com/yaq/yaqd-attune/-/blob/main/yaqd_attune/_attune_delay.py#L95

This is a problem specifically because yaqd-attune inserts dependents as entries into __dict__ (which it needs to do for some tuning things and simply to behave more like ophyd components.

However, since stage specifically has special meaning in bluesky (as a function) it is attempted to be called for a run which scans a delay. (Now, arguably it shouldn't attempt to call it because "unstage" is still undefined, and thus it does not pass the Stagable protocol check, but that is not what the RE actually uses to determine if it should call or not)

perhaps "wrapped_stage", or some other more explicit name is warranted.

ddkohler commented 2 years ago

@untzag

Bug in bluesky, in my opinion.

ddkohler commented 2 years ago

@untzag https://github.com/bluesky/bluesky/pull/1507

ddkohler commented 2 years ago

@ksunden

I still think we may wish to consider what we call it, even if the pull request is merged to make it not an immediate problem.

Partly just to avoid other subtle things in the duck typed codebase that is bluesky... partly in case we decide to implement yaq/yaq-traits#19, for which we ourselves would have such a method.I still think we may wish to consider what we call it, even if the pull request is merged to make it not an immediate problem. Partly just to avoid other subtle things in the duck typed codebase that is bluesky... partly in case we decide to implement yaq-traits#19, for which we ourselves would have such a method.