search

yaq-project / yaqd-picotech

ISC License
0 stars 1 forks source link

added freq argument to the _set_awg method #7

Open kameyer226 opened 2 years ago

kameyer226 commented 2 years ago

Added the frequency parameter to _set_awg

ksunden commented 2 years ago

Probably requires a config for the value, also needs to edit the line that calls this to work.

Also ignore the mypy error from pre-commit, it is unrelated

kameyer226 commented 2 years ago

moved back to kwarg, will not turn on until commanded by the exposed version of the method

untzag commented 2 years ago

As a very humble suggestion, consider adding a yaq property for this feature.

kameyer226 commented 2 years ago

Was the exposed method set_awg as a message in the toml what you had in mind?

kameyer226 commented 2 years ago

For some reason the voltage request range moved from strings like "1 V" to new strings such as "_1_V" so i had to update the daemon code to incorporate those new strings as keys, don't know why this was changed

ddkohler commented 2 years ago

For some reason the voltage request range moved from strings like "1 V" to new strings such as "_1_V" so i had to update the daemon code to incorporate those new strings as keys, don't know why this was changed

Looks like this is related to some yaq protocol changes made ~10 months ago. We updated the toml but not the python code.

kameyer226 commented 2 years ago

Wonder if simple changelog and possible comments on how code works plus parameters/outputs list updates can bypass review, it would seem rare for those kinds of edits to create a problem, and yet it could go a long way to adding "documentation" to the code