search

yaq-project / yaqd-thorlabs

GNU Lesser General Public License v3.0
1 stars 3 forks source link

Ell homing behavior relies on busy going to False before homing is complete #16

Open ksunden opened 2 years ago

ksunden commented 2 years ago

https://github.com/yaq-project/yaqd-thorlabs/blob/e94178baff6d1570614485a9bb28d01e20c8b4c1/yaqd_thorlabs/_thorlabs_ellx.py#L94

Uses await self._not_busy_sig.wait() to determine when to set the position.

This is less critical than ensuring that the set_position behavior is correct, as homing is usually only done by human interaction that is not rapidly polling the busy state, but still.

ksunden commented 2 years ago

There is not an explicit message for "home completed" as there is for APT, so some additional care must be taken here... shouldn't be that hard, but yeah.