search

yaquawa / jquery.photoswipe

The jQuery plugin for PhotoSwipe
91 stars 35 forks source link

Added custom PID support per image. Added line to documentation accordingly. #10

Open stamminator opened 7 years ago

stamminator commented 7 years ago

Now the data-pid attribute may be specified on the img tag. Added line in readme.md about the data-pid attribute.

ISSUES:

  1. Currently works whether or not the galleryPIDs: true option is set. Not sure if that's correct or not.
  2. If galleryPIDs option IS set to true, then the page should automatically open the image with the custom PID in the URI, but this is not working properly yet. Only default PIDs will open. If a custom PID is in the URI when the page loads, as soon as the user clicks on ANY gallery image, the image with that custom PID will open, rather than the one the user clicked on.
yaquawa commented 7 years ago

As you said, if you use the custom pid PhotoSwipe it won't open the slide for you, I think this is a bug of PhotoSwipe, so I'd like to postpone your pull request untile PhotoSwope fix this bug.