search

yaqwsx / KiKit

Automation tools for KiCAD
https://yaqwsx.github.io/KiKit
MIT License
1.53k stars 201 forks source link

Vcuts should be placed at top positions #615

Closed greenscreenflicker closed 9 months ago

greenscreenflicker commented 11 months ago

Prerequisites

KiKit version

kikit, version 1.3.0+16.gf84d28c

KiCAD version

7.0.7

Operating system

Windows 11

Description

The Vcuts are placed in the middle. Is there an option to place the vcuts at the top of a pcb, without specifying it manually?

Steps to Reproduce

Run the panalizing command with the pcb you already have from me.

grafik

Observe the vcuts, that are placed in the middle not, in the upper most position. Is there an option to specify this?

yaqwsx commented 11 months ago

Any cuts are placed only on places where the tabs are. In your case, you have a tab in the middle of the board. And the V-cut is there to cut the tab-board interface. You should position your tabs correctly (e.g., via annotation).

greenscreenflicker commented 11 months ago

Exactly, i could specify it manually. (see top: Is there an option to place the vcuts at the top of a pcb, without specifying it manually?) But could there be an option to automatically detect, that it's a vcut and always use the topest/lowest edge here? (it will be always true for vcuts, hence my proposal)

yaqwsx commented 11 months ago

KiKit is tab-oriented. Any cuts produced are generated from tabs. What you probably want is a new algorithm for tab placement: something like "edge tab" that will find the "outer-most" edge and placed tab there (which is a good idea and we should have it). It just shouldn't be coupled with V-cuts.

greenscreenflicker commented 11 months ago

@yaqwsx good proposal to keep it more versatile! +1 from my side. I like your proposal even more.

yaqwsx commented 9 months ago

When revisiting this, I just realized that this is exactly what the full tab does. It finds the outer most edges and spans a tab from them. So edges tabs are redundant.