search

yaqwsx / KiKit

Automation tools for KiCAD
https://yaqwsx.github.io/KiKit
MIT License
1.51k stars 200 forks source link

Add 'solderMaskMargin' parameter to Tooling #634

Closed c-jiph closed 6 months ago

c-jiph commented 7 months ago

JLCPCB's public documentation says tooling holes need to have a specific minimum solder mask expansion of 0.148mm. I couldn't find a way to easily specify this in KiKit though. I guess it's probably not that important or this would have been added earlier, but I thought it would be fun to do it anyway.

yaqwsx commented 7 months ago

Thank you for your contribution. The code looks good. Could also reflect the newly added options to documentation? Then I will be more than happy to merge the change.

c-jiph commented 7 months ago

Sure, hopefully my latest update is what is needed?

yaqwsx commented 7 months ago

Thanks, what is also needed is to document the new options here: https://github.com/yaqwsx/KiKit/blob/master/docs/panelization/cli.md

c-jiph commented 6 months ago

Okay, I added it. I'm not sure it will be a "common" option, but I think that's the most relevant place to put it?

yaqwsx commented 6 months ago

Looks good! Thanks!