search

yaqwsx / KiKit

Automation tools for KiCAD
https://yaqwsx.github.io/KiKit
MIT License
1.55k stars 201 forks source link

[Danger in Delay][JLCPCB] VCuts are not processed #728

Open greenscreenflicker opened 3 months ago

greenscreenflicker commented 3 months ago

Prerequisites

KiKit version

kikit, version 1.6.0

KiCAD version

8.0.4

Operating system

Windows 11

Description

I recently ordered panalized PCBs over JLCPCB. They came not panalized. Gerber: design_with_VCUTs(2) pcb_without_vcut

I asked JLCPCB how this could happen and their response is: After checking, this is due to Gerber layer issue. The V cut is located in layer panel-CmtUser.gbr, which cannot be verified by our system. Also, our engineer only proceed slot, v cut and outline based on GKO or GM1 layer. Pls kindly check the ordering instruction on our website: https://jlcpcb.com/help/article/14-instructions-for-ordering

Steps to Reproduce

see above.

greenscreenflicker commented 3 months ago

@bkballoon your account is compromised.

yaqwsx commented 3 months ago

JLC PCB is not "the single manufacturer we support". So, I am not willing to change the default behavior of KiKit panelization to match the non-standard and insane requirements of JLC PCB for V-cuts (they require the V-cuts to be in the Edge.Cuts layer, which breaks the 3D preview of the panel in KiCAD).

KiKit features built-in presets (https://github.com/yaqwsx/KiKit/tree/master/kikit/resources/panelizePresets); they, however, never got user attention and thus they are left abandoned. We could use a preset for JLCPCB V-cuts that would specify the V-cuts on the Edge.Cuts layer.

mikhailmihalkov commented 2 months ago

That's why there is a gerber file editor which is not in kicad. And they are indeed right because the cut is a mechanical layer

yaqwsx commented 2 months ago

@mikhailmihalkov As far as I know, there is no standardized meaning for Gerber layers. Every CAD does differently.

If I want to follow your logic, "it is a mechanical layer", I still think putting V-cuts into Edge.Cuts is wrong - the lines in the layer then have two different meanings:

If there is an international standard for gerber layers, I am more than happy to follow it. Otherwise, I don't want to make KiKit "JLC PCB first". I find the proposed solution via built-in presets for manufacturers to be the best one. If we should follow some conventions, then we should follow the conventions of KiCAD as KiKit is a tool for KiCAD.

mikhailmihalkov commented 2 months ago

There is no standard for the name, you can call it whatever you want, but it must be mechanical, the recognition system must clearly understand that it is mechanical. If you look at the picture above, there is no mechanical separation, but there must be a contour, this is how most cad work.

gcormier commented 2 months ago

If you are doing PCBA at JLC without choosing the approval option before it goes to fab, you're living life dangerously!

Personally I use KiKit/KiBot for tons of orders and have no issues with JLC and V-Cuts. I'm now using the JLC preset but only switched over maybe 3-4 months ago to that preset.

(BTW, I have a PR https://github.com/yaqwsx/KiKit/pull/677 that would let us specify which layer to put V-Cut notes, but I couldn't get it to only add the text to 1 layer. However I don't think this is related to your issue)

greenscreenflicker commented 1 month ago

@yaqwsx can you accept that pull request, as it would solve my problem.

greenscreenflicker commented 2 weeks ago

@yaqwsx ping