yaqwsx / KiKit

Automation tools for KiCAD
https://yaqwsx.github.io/KiKit
MIT License
1.53k stars 201 forks source link

KiKit places vcuts at wrong position #754

Open greenscreenflicker opened 2 days ago

greenscreenflicker commented 2 days ago

Prerequisites

KiKit version

kikit --version

KiCAD version

8.0.5

Operating system

Windows 11

Description

Kikit places vcuts at obviously wrong position.

grafik

Steps to Reproduce

Use panalizing command with PCB Send via email and observe same error

kikit panelize --layout "grid; rows: 1; cols: 5; space: 20mm; rotation: 90deg;" --tabs "fixed; hwidth: 10mm; vwidth: 60mm" --cuts "vcuts" --post "millradius: 0.3mm" --source "tolerance: 20mm" ../acpd_v1.kicad_pcb panel.kicad_pcb

yaqwsx commented 1 day ago

Well, where should they be placed, in your opinion? Please draw a picture.

I think the V-cuts are placed in the right position - where your tab meets the original PCB edge. I would say that your positioning of tabs in combination with V-cuts doesn't make sense.