yaqwsx / KiKit

Automation tools for KiCAD
https://yaqwsx.github.io/KiKit
MIT License
1.55k stars 201 forks source link

KiKit places vcuts at wrong position #754

Closed greenscreenflicker closed 2 weeks ago

greenscreenflicker commented 1 month ago

Prerequisites

KiKit version

kikit --version

KiCAD version

8.0.5

Operating system

Windows 11

Description

Kikit places vcuts at obviously wrong position.

grafik

Steps to Reproduce

Use panalizing command with PCB Send via email and observe same error

kikit panelize --layout "grid; rows: 1; cols: 5; space: 20mm; rotation: 90deg;" --tabs "fixed; hwidth: 10mm; vwidth: 60mm" --cuts "vcuts" --post "millradius: 0.3mm" --source "tolerance: 20mm" ../acpd_v1.kicad_pcb panel.kicad_pcb

yaqwsx commented 1 month ago

Well, where should they be placed, in your opinion? Please draw a picture.

I think the V-cuts are placed in the right position - where your tab meets the original PCB edge. I would say that your positioning of tabs in combination with V-cuts doesn't make sense.

greenscreenflicker commented 2 weeks ago

grafik There the vcuts should be placed.

yaqwsx commented 2 weeks ago

If the V-cuts were placed as you suggest, then the shape of PCB change as well. As I already said, I think the problem is in the position of you tabs. Please, have a look at the panel in the 3D Viewer - you will see the placement of the tabs makes no sense in this context. Please, place the tabs via manual annotation and everything will be as you expect.

yaqwsx commented 2 weeks ago

Based on your experience, I implemented a check if a V-cut damages the original PCBs in f972993dfdda8c17ce18ecde25d674b7c9391dad. The error message should clearly say what is the problem and suggest actions the user can take.

Screenshot from 2024-11-12 08-25-00