search

yaqwsx / PcbDraw-Lib

Model library for PcbDraw - https://github.com/yaqwsx/PcbDraw
Other
40 stars 19 forks source link

Add THT resistors #19

Closed Electro707 closed 2 years ago

Electro707 commented 2 years ago

A work-in-progress PR for adding THT resistor. This resistor has 4 bands with opacity 0, so this is what the resistor would look normally: image

But with https://github.com/yaqwsx/PcbDraw/pull/78, it will modify the band's color and opacity depending on the resistor value or if it is manually given: image

TODO:

Electro707 commented 2 years ago

image So this is what all resistors I plan on adding look like, created with a generator script. The script takes a base model's body and scales it and transforms it per resistor size.

The larger ones do look odd. Perhaps it would be better to adjust the body's nodes placement per size before applying a scale and transform per resistor size? Needs experimentation.

yaqwsx commented 2 years ago

I agree that the body shape (especially for the large ones) needs a little bit of tweaking. I would also introduce the terminal of the resistors. The floating body with terminals shown only on silkscreen looks weird. I am thinking of adding a slight shadow or gradient to the body would help the appeal of the drawing.

EDIT: I see there are terminals! In that case, I would choose a different color, possibly add a contour or gradient. Or make them thicker for larger resistors?

Electro707 commented 2 years ago

We can always just not include the larger size resistors which don't have a good ratio compared to the original. From a quick look at Digikey for those size resistors, they seems to be all the brick kind: image

Electro707 commented 2 years ago

Per commit 3d0e83e, I made the leads slightly darker (thoughts compared to the previous color?) and thicker. image

yaqwsx commented 2 years ago

Hi, first of all, I am sorry for the long delays. There was a lot of catching up with other projects. The new design looks OK to me. Do you consider this as finalized or do you plan to introduce more tweaks?

Electro707 commented 2 years ago

I probably would want to get rid of the larger resistors as they don't make sense to have this resistor style, and the fact they don't scale nicely.

Electro707 commented 2 years ago

image These are the resistors that I felt look alright and not too skewed. Should be good to merge now if you agree with the selected resistors

yaqwsx commented 2 years ago

Thanks!