search

yaqwsx / PcbDraw-Lib

Model library for PcbDraw - https://github.com/yaqwsx/PcbDraw
Other
40 stars 19 forks source link

THT Resistor Bands and Vertical #39

Open Electro707 opened 8 months ago

Electro707 commented 8 months ago

This PR adds a 5-color code bands and a zero/short band to the existing horizontal through-hole resistor models. The 5-color bands or the zero band is displayed by my fork of PCBdraw, see https://github.com/yaqwsx/PcbDraw/pull/156

This change is meant to be backwards compatible with the current implementation of coloring in pcbdraw.

This PR also adds some more resistor sizes, after checking that they are indeed the "bean" type in KiCAD. Proportions are off, so I need to fix that (perhaps even make a new template for those larger sizes)

This PR also adds vertical resistors.

Latest image: image

TODO:

Electro707 commented 7 months ago

image

I think this looks slightly better. Thoughts on improvement? (especially for the taller large ones)

yaqwsx commented 7 months ago

I think they look OK. One proposal - maybe adding a gradient to a darker color on one side or a thicker outline could increase the contrast between PCB and the resistor. Especially the resistors without the bands seem to blend with the PCB.