search

yaqwsx / PcbDraw

Convert your KiCAD board into a nicely looking 2D drawing suitable for pinout diagrams
MIT License
1.13k stars 90 forks source link

Make warning about back side components optional. #28

Closed set-soft closed 4 years ago

set-soft commented 4 years ago

Messages about missing *.back component images are emitted only if the --warn-back command line option is specified.

yaqwsx commented 4 years ago

I prefer having an inverse flag - to disable the warnings. Usually, you don't know that you might miss something and it is good to be notified about it. When you omit the components on purpose, you can specify an option to suppress the warnings.

set-soft commented 4 years ago

In general terms I agree with you, but this is a very particular case. The "*.back" components are 99% (or more) of the time things you won't include. You'll never want to include a back side SMD component and only in very particular cases you'll want to solder a through-hole component on the bottom layer. I don't have any problem on doing the flag the reverse because I will always use a wrapper to call pcbdraw, but forcing users to always include a flag doesn't seem like a good idea. Please tell me if you still wanting to invert it.

yaqwsx commented 4 years ago

When I am thinking about it now, none of the flags should be needed. We state the backside is required in the library. Therefore, I expect that all the SMD components in the library have a symlink to an empty component for the backside. If it is not present, it is a bug in the library. IMHO adding the symlinks for the components is no trouble.

set-soft commented 4 years ago

Ok, I added the links to dummy yaqwsx/PcbDraw-Lib#9 And made the option --no-warn-back

yaqwsx commented 4 years ago

It looks good to me. Thank you for your contribution.