Fix THT Resistor Color Related Code + Style Loading

yaqwsx / PcbDraw

Convert your KiCAD board into a nicely looking 2D drawing suitable for pinout diagrams

MIT License

1.16k stars 91 forks source link

Fix THT Resistor Color Related Code + Style Loading #93

Closed Electro707 closed 2 years ago

Electro707 commented 2 years ago

This PR fixes an issue with wrong callback functions in plot.py where it finds the values and colors for a THT resistor, and fixes the variable name used in ui.py where it gets the resistor values to be flipped.

Also fixed the style loading code, where it still looked at the old path and the load_style function was given name instead of the found path

yaqwsx commented 2 years ago

I was working in the past few days on adding (and fixing) type annotations on the whole project. The changes are now pushed and the types are checked in CI. I think all the bugs that this PR fixes are already addressed.

Please, test the resistor feature and if possible, add some tests for it.