search

yaqwsx / jlcparts

Better parametric search for components available for JLC PCB assembly
https://yaqwsx.github.io/jlcparts/
MIT License
554 stars 51 forks source link

Parallelize buildtables & update readme #97

Closed flaviut closed 1 year ago

flaviut commented 1 year ago
  1. the readme needed to be updated for the current cache size
  2. building the tables failed for me due to ValueError: could not convert string to float: '11.5u;12.5' in C3606553. Data quality has never been JLCPCB's strong suit, so I've changed the readme to suggest using --ignoreoldstock 30 which is likely more useful anyway.
  3. I've added parallelization of the table creation. This was very easy to parallelize, and I wanted to use all my cores.
    • --jobs 1 --ignoreoldstock 30: 75.08s user 3.66s system 100% cpu 1:18.40 total
    • --jobs 16 --ignoreoldstock 30: 122.83s user 7.66s system 638% cpu 20.422 total
    • original, --ignoreoldstock 30: 72.10s user 3.37s system 100% cpu 1:15.27 total
yaqwsx commented 1 year ago

Thanks! Makes perfect sense and looks good to me. Merging.