search

yarcat / chemistry-lines

Chemistry Lines (game)
1 stars 0 forks source link

Generated KnownFormulas contains terminal "O" that does not start a compound. #23

Closed soulne4ny closed 11 years ago

soulne4ny commented 12 years ago 
    private final static void registerO() {
        E("O")
            .isFinal(true);

Where it comes from?

soulne4ny commented 12 years ago

It comes from here http://en.wikipedia.org/wiki/Dictionary_of_chemical_formulas#O

So the formila O (CAS number 7782-44-7) duplicates a terminal O.

soulne4ny commented 12 years ago

O is marked final, but SimpleReactor does not remove it from the board. Should we remove isFinal mark explicitly?

yarcat commented 12 years ago

It's quite a funny situation with O. I understand exactly why this happens, and think that it's worth fixing this.

yarcat commented 12 years ago

Generally the code in the element-duplicates branch looks good, I suggest to split it into two commits – O related and everything else (as a single commit). And submit it to master.

soulne4ny commented 12 years ago

You mean just squash first 2 commits?

yarcat commented 11 years ago

Rollback Tests/.classpath, squash, commit (-;