yarcat / chemistry-lines

Chemistry Lines (game)
1 stars 0 forks source link

Score based on atoms. #65

Closed soulne4ny closed 11 years ago

soulne4ny commented 11 years ago

Add simple score that is total number of atoms of all removed compounds. Requires #52 to be done.

soulne4ny commented 11 years ago

1

soulne4ny commented 11 years ago

My first idea was to create weighted score counted by registry generator. Then I did just an atom score. Now I suppose it would be better to sum atomic masses. Isn't it?

soulne4ny commented 11 years ago
$ git push -f origin atom-score
Counting objects: 35, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (12/12), done.
Writing objects: 100% (19/19), 1.93 KiB, done.
Total 19 (delta 11), reused 0 (delta 0)
To git@github.com:yarcat/chemistry-lines.git
 + ef66353...4557b2f atom-score -> atom-score (forced update)
yarcat commented 11 years ago

Looks awesome! I just think that we have to change the label from Atoms to just plain Score. The thing is that it doesn't necessary reflects amount of removed atoms there, right? Or, we can show how many atoms were removed + score as additional thing. Wdyt?

soulne4ny commented 11 years ago

I just wrote Atoms to show that there are no bonuses. I'll put Score.

soulne4ny commented 11 years ago

Rebase on master

$ git push -f origin atom-score
Counting objects: 52, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (21/21), done.
Writing objects: 100% (31/31), 2.96 KiB, done.
Total 31 (delta 18), reused 0 (delta 0)
To git@github.com:yarcat/chemistry-lines.git
 + 78eeedb...1023cfa atom-score -> atom-score (forced update)
soulne4ny commented 11 years ago

Now formulas with parenthesis have correct atom count.

soulne4ny commented 11 years ago

Yar, please, review https://github.com/yarcat/chemistry-lines/commit/ce2161163cc303d1152fb714cd23e146e8bf1fec. Reopen, if there is smth to fix.