yard-turkey / aws-s3-provisioner

21 stars 16 forks source link

What are your Long-term plans? #85

Open ykoer opened 3 years ago

ykoer commented 3 years ago

Hi,

what are your long-term plans with the AWS S3 Operator since lib-bucket-provisioner is deprecated. I am asking because I would like to contribute the tagging and server-side bucket encryption support.

Thanks Yusuf

screeley44 commented 3 years ago

Hi @ykoer - There are no long term plans for this particular provisioner. This was a proof of concept project to help test and evaluate the now deprecated object-bucket-library when it was first being developed.

As the OB Library has been transformed into an official upstream Kubernetes SIG repo - Container Object Storage Interface (COSI), I think it makes sense to start using and contributing to that. Below are some links

KEP: https://github.com/kubernetes/enhancements/pull/2100

Project Repos: https://github.com/kubernetes-sigs/container-object-storage-interface-csi-adapter https://github.com/kubernetes-sigs/container-object-storage-interface-controller https://github.com/kubernetes-sigs/container-object-storage-interface-spec https://github.com/kubernetes-sigs/container-object-storage-interface-api https://github.com/kubernetes-sigs/container-object-storage-interface-provisioner-sidecar

ykoer commented 3 years ago

Hi Scott,

I Added support for turning ObjectBucketClaim labels into S3 Bucket Tags and default server-side encryption which can be enabled with an annotation ("aws-s3-server-side-default-encryption") in the storage class.

See: https://github.com/ykoer/aws-s3-provisioner/commit/45f277573c43261bd5ad7fb93dc6cdf6d9c55b8c

Unfortunately, a change in the lib-bucket-provisioner library was also required, because all labels are getting overwritten. https://github.com/ykoer/lib-bucket-provisioner/commit/94ac4a6c86af16399d1be509dd8eb8b07100c074

Let me know if you are interested. I can send a PR.

Thanks Yusuf