search

yardencsGitHub / tweetynet

Hybrid convolutional-recurrent neural networks for segmentation of birdsong and classification of elements
BSD 3-Clause "New" or "Revised" License
47 stars 9 forks source link

BUG: remove 'padding' from kwargs to fix #166 #170

Closed NickleDave closed 2 years ago

NickleDave commented 2 years ago

removes 'padding' argument of Conv2d from kwargs only when calling super as described in #166

This also fixes https://github.com/NickleDave/vak/issues/370

NickleDave commented 2 years ago

@yardencsGitHub I tested this locally with both torch==1.7.1 and torch==1.8.0 and found I was able to run predict without getting the error

I need to test more, but pretty sure this will fix the bug and still maintain backward compatibility as described in #166

NickleDave commented 2 years ago

Tests pass, that use nox to confirm with multiple versions of torch. Merging in

NickleDave commented 2 years ago

@all-contributors please add @zhehao-nkd for bug

allcontributors[bot] commented 2 years ago

@NickleDave

I've put up a pull request to add @zhehao-nkd! :tada: