A fix to vak logging required removing the parameter logger from the from_config method, which is a breaking change.
For that reason a new version was released, 0.6.0.
Using the current TweetyNet version with vak 0.6.0 will raise an error because TweetyNetModel will try to pass in the logger parameter as an argument when it initializes the class.
Need to:
[ ] remove the logger argument that TweetyNetModel.from_config passes into cls, and from the signature of the classmethod itself
[ ] need to raise the upper bound on vak to 0.6.0
[ ] then release a new TweetyNet version. I guess 0.8.0 :shrug: since we also make a "breaking" change to TweetyNetModel, on the off chance someone is using ijt programatically
NickleDave
commented
2 years ago
A fix to
vaklogging required removing the parameterloggerfrom thefrom_configmethod, which is a breaking change. For that reason a new version was released, 0.6.0.Using the current TweetyNet version with vak 0.6.0 will raise an error because TweetyNetModel will try to pass in the logger parameter as an argument when it initializes the class.
Need to:
loggerargument thatTweetyNetModel.from_configpasses intocls, and from the signature of the classmethod itselfvakto 0.6.0