Added debug mode, made adapter system much tidier

BlueDrink9 commented 5 years ago

Thought I'd have a bash at doing something more to your liking, building on #8.

The adapters now all declare functions.
The modelines are gone (sorry)
Move adapter-specific code to adapter file (including options and FILTER_URL)
Remove coupling to jq for adapters (note that 1pass requires jq anyway).
Again, only the lpass stuff is tested. Theoretically I haven't changed the on bits, but I can't test them so if you feel generous, let me know if they are broken.

This still makes this program a framework, but I cannot fathom how you plan on making a generic version without one. To me, a framework is a generic version, and vice versa.

If you reject this approach too, I'll stop bugging you with PRs and just maintain my own fork, so long as you're happy with me doing that.

This would also (at least partially) fix #5.

BlueDrink9 commented 5 years ago

@yardnsm I don't want to push you if you don't have time, but if you do, any feedback/response here?

yardnsm commented 5 years ago

Hey @BlueDrink9, sorry for the late response 😅

Unfortunately I'll close this PR, as it still a pretty big refactor and still has some issues mentioned in https://github.com/yardnsm/tmux-1password/pull/8#issuecomment-455252024.

I really appreciate the effort though, I can add a link to your fork in the README under a "lastpass support" section if you'd like.

BlueDrink9 commented 5 years ago

Thanks, a link will be fine.

yardnsm / tmux-1password

Added debug mode, made adapter system much tidier #9