search

yargs / cliui

easily create complex multi-column command-line-interfaces.
ISC License
371 stars 41 forks source link

Should npm run script `check` run after `test`? #141

Open shadowspawn opened 1 year ago

shadowspawn commented 1 year ago

There are some minor benefits to having the lint check separate from the runtime tests, so that more of the GitHub Action checks complete and aren't blocked by lint issues. However, makes it easy to open a PR and push code that will fail on the lint check.

I noticed there is postest run script, which should presumably be posttest! Leaning towards enabling that as I tend to only fix one breakage at a time anyway.

https://github.com/yargs/cliui/blob/af3145da0ea31738c4715865a6da0ee388a94c74/package.json#L23

Fixing that would render this line obsolete:

https://github.com/yargs/cliui/blob/af3145da0ea31738c4715865a6da0ee388a94c74/.github/workflows/ci.yaml#L24

shadowspawn commented 1 year ago

Currently the check is a bit noisy due to dependencies. Might be a good time to make this change when drop node 12 and update dependencies.

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <4.5.0

YOUR TYPESCRIPT VERSION: 4.9.5

Please only submit bug reports when using the officially supported version.

=============