yargs / y18n

:ledger: the bare-bones i18n library used by yargs
ISC License
146 stars 48 forks source link

chore: export Y18N class #136

Open dopry opened 3 years ago

dopry commented 3 years ago

allows users to explicitly construct their Y18N instance with their own choice of shim.

dopry commented 3 years ago

@bcoe who should I contact about reviewing and merging this PR?

bcoe commented 3 years ago

@dopry thanks for the patch, I will do my best to land soon.

dopry commented 3 years ago

@bcoe hey do you need me to rebase this or anything? I'm still running on a fork and would really like to get back on upstream.

bcoe commented 3 years ago

@dopry my bad, I lost track of this. It looks like this potentialy breaks the ESM exports unfortunately, any ideas?

dopry commented 3 years ago

It looks like I needed to leave out the opts interface in the CJS file. JS doesn't understand interfaces. It should pass now.

dopry commented 2 years ago

not off hand. I'm busy on other projects for the foreseeable.