Open tasshi-me opened 1 year ago
As a sanity check I looked at what some of the other Yargs libraries have, and import entry point and "module"
do match each other.
https://github.com/yargs/cliui/blob/af3145da0ea31738c4715865a6da0ee388a94c74/package.json#L6-L16
I note you put fix!
for a breaking change in the title. Do you feel it is a breaking change, or is it just a bug fix?
(I don't have much experience with bundlers and interested in your reasoning.)
@shadowspawn
Thank you for reviewing! You can remove !
.
I added it because this PR may break environments using older versions of bundlers that don't support the exports
field.
I don't know how many users use this package directly and are impacted.
I checked when webpack and rollup started supporting exports.
Thanks for info, and good links.
I found a couple of links covering background and usage of the "module" main field:
@shadowspawn
Thank you for letting me know!
module
field is not official, but major bundlers supported it in old versions.y18n
has 1,048 dependents.Now, my idea...
fix
, because it changes the interface for old bundlers, but the user impact is small fix!
, even if user impact is small
I respect your decision.
This PR fixes https://github.com/yargs/y18n/issues/155.
I made the entrypoint specified in the
module
field the same asexports
.