search

yarhrn / new-scaladoc

3 stars 1 forks source link

Type link #33

Closed yaroslavhq closed 9 years ago

yaroslavhq commented 9 years ago

fixes #21

cvogt commented 9 years ago

apart from the things I mentioned LGTM

clhodapp commented 9 years ago

One general comment: I really don't like seeing String adding via +. I much prefer ++. There's more overhead, but I'll eat that in exchange for knowing that I'm not accidentally calling toString on things when I didn't mean to.

cvogt commented 9 years ago

super type support LGTM