search

yarikpwnzer / react-native-survey-monkey

React Native lib for Survey Monkey
22 stars 17 forks source link

fix: Xcode 12 compatibility #17

Closed r3nya closed 3 years ago

r3nya commented 3 years ago

Summary

Latest Xcode 12 fails to build while without a module to depend on React-Core directly hence this change is necessary for all native modules on iOS. This change requires React Native 0.60.2 or newer. For more details please check: facebook/react-native#29633 (comment)

yarikpwnzer commented 3 years ago

@r3nya seems good to go. Thx.

r3nya commented 3 years ago

Great! Thanks for review and your work. ;)

r3nya commented 3 years ago

Hi @yarikpwnzer!

Sorry but can you bump package version with this change please? :)

yarikpwnzer commented 3 years ago

Bumped. I'm sorry, I totally forgot about that.

вт, 6 июл. 2021 г. в 22:46, Andrew M. @.***>:

Hi @yarikpwnzer https://github.com/yarikpwnzer!

Sorry but can you bump package version with this change please? :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/yarikpwnzer/react-native-survey-monkey/pull/17#issuecomment-875034943, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJPWN7YCG4QQCDBJOBYWX3TWNMSHANCNFSM47TGDGCQ .

r3nya commented 3 years ago

No problems, thanks man! :)