yariksav / vuetify-confirm

Extends vuetify.js confirm dialog
MIT License
143 stars 42 forks source link

Errors when using with latest vue/vuetify #15

Closed garyo closed 5 years ago

garyo commented 5 years ago

It works fine, but I see these errors in the JS console:

vue.runtime.esm.js?2b0e:619 [Vue warn]: Missing required prop: "message"
(found in <Root>)

It happens at line 7 of index.js where the component is first created. The message prop isn't passed into the component there, only on the next line (line 13):

      const cmp = new Vue(Object.assign(Confirm, {
        destroyed: (c) => {
          document.body.removeChild(cmp.$el)
          resolve(cmp.value)
        }
      }))
      Object.assign(cmp, Vue.prototype.$confirm.options || {}, options)

Perhaps a null message (or the actual one) could be passed in to the initial construction to prevent that error?

yariksav commented 5 years ago

Hi, @garyo. This error already solved in #13. I guess you use old version of module. Please use latest 0.2.5 npm i vuetify-confirm@latest

garyo commented 5 years ago

Ha, thanks -- you're too fast! 😄 Thanks!

yariksav commented 5 years ago

Best wishes! :)