search

yarindeoh / safe-home-haytiSham

THE MICHAL SELA HACKATHON
https://hayti-sham.co.il/
5 stars 4 forks source link

Create "All Tags" button and functionality for homepage #105

Closed moranw closed 4 years ago

moranw commented 4 years ago

As seen on the homepage on Figma - When first loading the page - this button should be selected, meaning the first page of stories should be loaded (getStoriesByTags can get no tags and then it returns all)

ghost commented 4 years ago

I added all tags button as part of issue #106 . In order to be able to add the needed functionality to the button, someone needs to implement server-side ability to return all the stories (without tag ids). Please do not implement 'all tags' on the frontend side until I push #106.

yarindeoh commented 4 years ago

@hadasfarhi We've decided that allTags button is confusing. Please hold until we'll get a product decision.

ghost commented 4 years ago

@yarindeoh @moranw I implemented the changes we agreed on at Monday's meeting. I wanted to draw your attention to a problem - when someone clicks on "all tags," the stories list displays stories written for testing purposes that are not linked to any tag. Is the development database is also intended for production usage? If it is, maybe it will be better to delete the fictive stories.