search

yarindeoh / safe-home-haytiSham

THE MICHAL SELA HACKATHON
https://hayti-sham.co.il/
5 stars 4 forks source link

Change all text from json (lang.json), no plain text in components is allowed #35

Closed yarindeoh closed 4 years ago

yarindeoh commented 4 years ago

Maybe needs to add localization - I18n or other solution. Or keep using lang.json

grount commented 4 years ago

@yarindeoh Hey, I would like to help with this. I would consider using i18next and move from lang.json to js files starting from Hebrew as the default language. this change will be a breaking change for all the front-end not merged changes, if you would like to I can wait in order to avoid conflicts. WDYT?

yarindeoh commented 4 years ago

@grount Sounds great! You can work on it. We are waiting for the server refactor change so we are mainly working on style changes