search

yarivShamash / jammming

CodeCademy FEApps Project
1 stars 0 forks source link

Summary #1

Open Tzuridis opened 5 years ago

Tzuridis commented 5 years ago

Rubric Score

Criteria 1: CRA Project Creation & Structure

  • Score Level: 4/4 (Exceeds Expectations)
  • Comment(s): Your file structure is good. You made a CRA app and all of the components are properly located inside of folders, with the file paths working as well. Nice work!

Criteria 2: Data Flow

  • Score Level: 4/4 (Exceeds Expectations)
  • Comment(s): You met most of the requirements for data flow within the app. You did well working with Spotify and showed good understanding of how it worked. Your search functionality was well done and your playlist manipulation was also great. Nice work!

Criteria 3: Syntax

  • Score Level: 4/4 (Exceeds Expectations)
  • Comment(s): You hit upon all of the syntax requirements here. You used className when applying classes and used JSX instead of pure HTML. You also added keys to each of the tracks in your track list. Nice work!

Criteria 4: DRY Code/Style

  • Score Level: 4/4 (Exceeds Expectations)
  • Comment(s): You did well keeping your code "DRY." Great job separating out the beginning of the API urls into a variable as this allows you to change the base url of the API for all endpoints that used it by writing once, instead of updating each method separately. Also a great job on your comments/notes in your code, it made it very easy to review. Good job.

Overall Score: 16/16

Overall, you did a great job with this project. You implemented all of the features of the project and wrote "DRY" code. Your data flow through the app was great and you did a good job working with the Spotify API. A lot of learners experience trouble when working with Spotify, so it is great to see that you were able to get it. Awesome work!

yarivShamash commented 5 years ago

Dear @Tzuridis

Thank you very mmuch for your review and the comments. It made my day, sepecially since I had a very hard time with this project, sepecially towards the end of it. Could you explain why doesn't the app work? I tried to figuer it out by myself but coudln't come up with anything..

All the best,

Yariv Shamash :)

Tzuridis commented 5 years ago

Hi yariv I believe the issue is in the spotify.js file. Take a look here:

https://s3.amazonaws.com/codecademy-content/programs/react/project-solutions/bwa_u3_jamming_solution.zip