yarl / pattypan

Upload files to Wikimedia Commons. The Spreadsheet Way.
https://commons.wikimedia.org/wiki/Commons:Pattypan
MIT License
56 stars 37 forks source link

Add Github action for building EXE #173

Closed sebastian-berlin-wmse closed 11 months ago

sebastian-berlin-wmse commented 1 year ago

Bug: #152

Abbe98 commented 1 year ago

I would like to look into porting it to linux/bash but I'm a little short on time currently.

On Tue, Apr 11, 2023 at 12:13 PM sebastian-berlin-wmse < @.***> wrote:

@.**** commented on this pull request.

In .github/workflows/ant.yml https://github.com/yarl/pattypan/pull/173#discussion_r1162597930:

@@ -0,0 +1,45 @@ +name: Make self-contained Windows EXE + +on:

  • workflow_dispatch:
  • push:
  • tags:
    • v*
  • +jobs:

  • build:
  • runs-on: windows-latest

Was there a review action here or are these just notes for how this could be developed further?

— Reply to this email directly, view it on GitHub https://github.com/yarl/pattypan/pull/173#discussion_r1162597930, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUCQJYRAVWVF37FSMD6QNDXAUVFPANCNFSM6AAAAAAWCO4WEY . You are receiving this because you commented.Message ID: @.***>

sebastian-berlin-wmse commented 1 year ago

OK, so that's a possible further development and not something to do for this PR, right? This is specifically for Windows.

Abbe98 commented 1 year ago

I would like to build Windows binaries on Linux. Actions aren't an option as explained elsewhere, however, we could probably make a new release given the commands in this merge request.

On Wed, Apr 12, 2023 at 8:45 AM sebastian-berlin-wmse < @.***> wrote:

OK, so that's a possible further development and not something to do for this PR, right? This is specifically for Windows.

— Reply to this email directly, view it on GitHub https://github.com/yarl/pattypan/pull/173#issuecomment-1504749355, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUCQJ6JXID523B6R6BELZLXAZFQNANCNFSM6AAAAAAWCO4WEY . You are receiving this because you commented.Message ID: @.***>

lokal-profil commented 1 year ago

Hi @Abbe98, Sorry for the long silence on this issue. Finally found the time to come back to it.

It's a bit unclear to me what exactly the issues are. If I’m understanding them correctly there are two separate ones.

To build the Windows stand-alone .exe file the Action job needs to run on Windows (which is proprietary).

Using Github Actions costs minutes (and Windows even more so) which is a limited resource for you (per https://github.com/yarl/pattypan/issues/152#issuecomment-1478082351).

Is this understanding correct?

For 1) I believe @sebastian-berlin-wmse answered this in https://github.com/yarl/pattypan/issues/152#issuecomment-1478145002. I.e. the .exe needs to be created in the same OS as the result should be run on (since it doesn’t create an installer but a directly executable version of Pattypan). This would mean that even were you to run this locally you would need Windows.

For 2) This Action should only ever run when there is a new release. Which historically is not very often. The job takes around 2 minutes (so 4 minutes with the Windows multiplier). If it is run on this repo then those minutes should be taken from Yarl’s pool of free minutes right?

Either way we’d like to find a way forward on this since there is now a real use case for these executables and the most natural place for them to live is attached to the official repo.

Cheers, André