first shot at implementing https://github.com/yarl/vicuna/issues/98

yarl / vicuna

Tool for uploading files to Wikimedia Commons and other Wikimedia projects

http://yarl.github.io/vicuna/

43 stars 23 forks source link

first shot at implementing https://github.com/yarl/vicuna/issues/98 #102

Closed FlominatorTM closed 3 years ago

FlominatorTM commented 7 years ago

I don't know if it's bold the simply retrieve that field all the time, but I thought I give it a shot anyway ...

saper commented 7 years ago

Looks good to me, do you have some test files to try it on?

Also there is something wrong with the whitespace, have a look at your git show output

FlominatorTM commented 7 years ago

@saper Thanks for having a look at it. I'm not 100% sure (currently not at my machine), but according to metadata information https://commons.wikimedia.org/wiki/File:%28Wasser-%29Schloss_Birkenreute_in_Kirchzarten_2.jpg should have this IPTC data.

Can you give me a hint on what exactly to look for regarding the whitespace?

saper commented 7 years ago

Sure, just have a look at https://github.com/yarl/vicuna/pull/102/files and you will see that some lines are moved to the right strangely. Most probably you have tabs somewhere where we use spaces.

Also avoid adding empty new lines if not necessary.

FlominatorTM commented 7 years ago

Better like this? Thank you for your patience, this is my first pull-request that I get feedback for :)

FlominatorTM commented 7 years ago

@saper Is the additional commit better regarding indention?

michal-josef-spacek commented 3 years ago

Rewrite this PR to #157