search

yarl / vicuna

Tool for uploading files to Wikimedia Commons and other Wikimedia projects
http://yarl.github.io/vicuna/
42 stars 24 forks source link

action=query&prop=info&intoken API calls #154

Closed reedy closed 3 years ago

reedy commented 3 years ago

In support of https://phabricator.wikimedia.org/T280806, it seems VicunaUploader/1.23 (at least) is still doing action=query&prop=info&intoken API calls.

I can't see if this has been fixed in the many commits since 1.23 in https://github.com/yarl/vicuna/compare/1.23...master but if it's not... can someone please fix it?

And if it is fixed... Any chance we can get a release to stop these calls happening by people upgrading?

Thanks!

michal-josef-spacek commented 3 years ago

@reedy Could you check 1.24-beta2?

reedy commented 3 years ago

I'm guessing this may have been fixed due to some update of the https://github.com/MER-C/wiki-java inside vicuna...

Based on https://github.com/MER-C/wiki-java/blob/05aae5a87498c187c533909eb448b7923e70f011/src/org/wikipedia/Wiki.java#L1486-L1502 added in https://github.com/MER-C/wiki-java/commit/9dc236e644cc1dc6ddd33ec964a9f018f207af9a

Based on https://github.com/yarl/vicuna/blob/1.23/src/org/wikipedia/Wiki.java which used intoken

When 1.24 goes stable and people update, that should mostly fix up the issue

michal-josef-spacek commented 3 years ago

@reedy Yes, i updated Wiki.java to some version, still i cannot update to last version, because some issue :-/

Last pre-release is: https://github.com/yarl/vicuna/releases/tag/1.24-beta2 we need to check. When i am looking to code, this intoken isn't here. So i am closing ticket. Thanks :-)