yarl / vicuna

Tool for uploading files to Wikimedia Commons and other Wikimedia projects
http://yarl.github.io/vicuna/
43 stars 23 forks source link

UI text invisible when using "dark" theme in Ubuntu 20.04 LTS #163

Open ElGrafo opened 3 years ago

ElGrafo commented 3 years ago

As the title says, almost all text in the main window is invisible when using the dark mode (in the "Appearance" settings in Ubuntu, set "Window colors" to Dark) of Ubuntu 20.04 (tested with 1.24-beta3). That's because the text is (correctly) converted from black to white, but the white background is not converted to something dark. Interestingly, the "logged off" is visible as black on white, so it would be invisible on the correct dark background. See attached file … vicuna_UI_problems

michal-josef-spacek commented 3 years ago

@ElGrafo crazy! I will look to it.

michal-josef-spacek commented 3 years ago

@ElGrafo Could you send me your java swing setting?

I tested this (only one from list) [set env variable in bash]: export _JAVA_OPTIONS="-Dawt.useSystemAAFontSettings=on -Dswing.aatext=true -Dswing.defaultlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel -Dswing.c rossplatformlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel"

export _JAVA_OPTIONS="-Dswing.metalTheme=steel"

export _JAVA_OPTIONS="-Dswing.metalTheme=ocean"

export _JAVA_OPTIONS="-Dswing.crossplatformlaf=com.sun.java.swing.plaf.motif.MotifLookAndFeel"

export _JAVA_OPTIONS="-Dswing.crossplatformlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel"

All seems ok, so as I understand you have special setting and i don't know how to reproduce. I believe that you could set to another setting.

michal-josef-spacek commented 3 years ago

@ElGrafo And could you send image from 1.23?

ElGrafo commented 3 years ago

He, thanks for looking into this!

@ElGrafo And could you send image from 1.23?

1.23 looks slightly worse (sorry, cannot load an image, 1.23 is pretty broken on Ubuntu: gnome-shell-screenshot-WXB160

@ElGrafo Could you send me your java swing setting?

TBH, I have no clue what that means (I don't speak Java) and Google wasn't helpful either. Is there a command for that? Meanwhile, here's my Java version, if that helps:

$ java --version
openjdk 11.0.11 2021-04-20
OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.04)
OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.20.04, mixed mode, sharing)

All seems ok, so as I understand you have special setting and i don't know how to reproduce. I believe that you could set to another setting.

Hmm, I'm running a pretty much vanilla Ubuntu 20.04 here. As I wrote above, I changed the system's appearance to use the dark mode (afaict, that's the yaru-dark Gnome theme), but that's about it.

michal-josef-spacek commented 3 years ago

@ElGrafo As i understand there must be some setting as i wrote "swing.someting=something" or whatever. Maybe there is mode for use gtk setting (and use -Dswing.crossplatformlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel).

I don't know what i could do in this actually. :-(

ElGrafo commented 3 years ago

The same thing happens on a different machine with Ubuntu 21.04. There's an easy work-around, though: I just temporaily swith to Standard or Light mode and everything looks as usual. So don't waste your precious time on this. In fact, this might just as well be a bug in GTK or Ubuntu or something.

Just FTR: On Windows 10, Vicuna completely ignores the dark mode setting of the operating system and stays as white as it always has been.