search

yarl / vicuna

Tool for uploading files to Wikimedia Commons and other Wikimedia projects
http://yarl.github.io/vicuna/
43 stars 23 forks source link

Option to disable getCurrentDatabaseLag check - fixes #40 #41

Closed saper closed 9 years ago

saper commented 9 years ago

Implements GUI option "Monitor server status (database lag)".

Database lag is checked only when this option is enabled AND the user is logged in. The user can turn this option on and off during the session at will. Changes should be visible immediately in the interface.

Implementation details:

ServerMonitor is designed to be pretty independent from the rest of the application. Ideally it would only listen to events.

The GUI widget component should really be separate.

One property in Data and Data.settings have been converted to use Javabean accessors, in order to enable possibility to listen on changes. Probably the code could got simpler if other settings became bound properties as well.

This code has been developed in vi only and therefore little attention have been paid to the form definition files. It is also possible that some imports can be removed, maybe there are some warnings introduced.

It is confusing to decide whether to access Data via static methods or as an instance variable (this.data). I tried to use the latter, mostly.

Thanks for writing Vicuna! It is really good.

saper commented 9 years ago

All commits from d94d52a..6dfb348 are to cleanup/silence warnings and clean up build infrastructure a bit.

We should also stop pretending we run on Java 5.