yarnpkg / berry

πŸ“¦πŸˆ Active development trunk for Yarn βš’
https://yarnpkg.com
BSD 2-Clause "Simplified" License
7.43k stars 1.11k forks source link

[Chore] Fix our peer dependency warnings #418

Open arcanis opened 5 years ago

arcanis commented 5 years ago

We have various peer dependency warnings displayed when running yarn install inside our own repository. It would be great if we could fix the upstream packages to stop it from happening, as it's a matter of time before it causes more serious issues:

image

Given a warning:

X doesn't provide Y requested by Z

The best fix is generally to either:

jj811208 commented 2 years ago

This PR will fix both warnings: https://github.com/yarnpkg/berry/pull/4935

➀ YN0060: β”‚ @yarnpkg/monorepo@workspace:. provides eslint (pf82c3) with version 8.2.0, which doesn't satisfy what @yarnpkg/eslint-config and some of its descendants request
➀ YN0002: β”‚ acceptance-tests@workspace:packages/acceptance-tests doesn't provide jest (pcc8ab), requested by jest-json

these are all gatsby related, many repositories have been archived and we can't do anything about them.

but these will no longer be a problem after https://github.com/yarnpkg/berry/pull/4851, I believe we have a reason to leave them alone

➀ YN0002: β”‚ gatsby-cli@npm:3.14.0 [7243a] doesn't provide ink (p4a7fc), requested by gatsby-recipes
➀ YN0002: β”‚ gatsby-plugin-manifest@npm:3.7.0 [118b2] doesn't provide graphql (p0cd4a), requested by gatsby-plugin-utils
➀ YN0002: β”‚ gatsby-plugin-page-creator@npm:3.14.0 [7243a] doesn't provide graphql (pd3e76), requested by gatsby-plugin-utils
➀ YN0060: β”‚ gatsby-recipes@npm:0.25.0 [bb88b] provides graphql (pc0633) with version 15.5.0, which doesn't satisfy what graphql-subscriptions 
➀ YN0002: β”‚ gatsby@npm:3.14.0 [118b2] doesn't provide babel-eslint (p70342), requested by eslint-config-react-app
➀ YN0002: β”‚ react-instantsearch-dom@npm:6.6.0 [118b2] doesn't provide algoliasearch (p65251), requested by algoliasearch-helper
➀ YN0002: β”‚ react-instantsearch-dom@npm:6.6.0 [118b2] doesn't provide algoliasearch (p5ab0d), requested by react-instantsearch-core
➀ YN0002: β”‚ @endemolshinegroup/cosmiconfig-typescript-loader@npm:3.0.2 [714f3] doesn't provide typescript (p88d18), requested by ts-node
➀ YN0002: β”‚ @yarnpkg/gatsby@workspace:packages/gatsby doesn't provide @emotion/core (pa19bb), requested by gatsby-plugin-mdx
➀ YN0002: β”‚ @yarnpkg/gatsby@workspace:packages/gatsby doesn't provide webpack (pe1aa2), requested by gatsby-plugin-favicon

I found some PRs about this: https://github.com/algolia/algoliasearch-helper-js/pull/746 https://github.com/algolia/react-instantsearch/pull/2811 https://github.com/EndemolShineGroup/cosmiconfig-typescript-loader/pull/133 https://github.com/Creatiwity/gatsby-plugin-favicon/pull/65


These are all the warnings we have, I think we can close this issue, or remove the first-good-issue tag to prevent people from spending time on it, and wait for a successful conversion to docusaurus

ArchitGajjar commented 10 months ago

Hi @arcanis can you please assign this to me ?

ArchitGajjar commented 10 months ago

NVM, I think @jj811208 already have fixed this in his PR above πŸ‘