Closed clemyan closed 3 months ago
Oh and I forgot to mention, regarding the dependencies, there are a few that I don't know what to do with them
@codesandbox/sandpack-react
: as far as I can tell this was used for the sherlock playground? I tried to remove it but that would remove a lot of transitive deps and I am weary of introducing churn if and when we rebuild the playground.markdown-it-br
and marked-base-url
: these are plugins to markdown-it
and marked
respectively? They are not imported anywhere but I don't know how markdown-it
and marked
discover/load plugins so I'm not sure whether they are used or not.For this PR I'm not touching them since there is no harm but I'm generally all for removing unnecessary deps.
Also, in theory, all the default plugins are dependencies of the docusaurus workspace because they are needed to generate the CLI docs. So, in theory we should list all of them as dependencies. This would have the benefit that (together with this PR) that the website can be built with a production-only focused docusaurus workspace but I'm not sure if the maintainence burden is worth that.
Side quesetion: Why is the website built with --no-minify
on Netlify?
Side quesetion: Why is the website built with
--no-minify
on Netlify?
I don't remember a particular reason 🤔
What's the problem this PR addresses?
Some minor/nitpick-level problems with the website
Note: This PR has some overlap with #6218. I'll rebase one when the other is merged
How did you fix it?
create-docusaurus
docusaurus.config.ts
itself) to aconfig
directory. May not seem like much but as more stuff gets added this can keep thing clean and manageable.yarn build
successfully is a dep and devDeps are those that are purely for DX (e.g. types)Checklist