search

yarnpkg / yarn

The 1.x line is frozen - features and bugfixes now happen on https://github.com/yarnpkg/berry
https://classic.yarnpkg.com
Other
41.38k stars 2.72k forks source link

Not all packages included in generate-disclaimer #3111

Open ariporad opened 7 years ago

ariporad commented 7 years ago

Do you want to request a feature or report a bug? Bug

What is the current behavior? Not all packages are included in yarn licenses generate-disclaimer.

If the current behavior is a bug, please provide the steps to reproduce.

mkdir tmp
cd tmp
yarn init -yy
yarn add nodetunes
yarn licenses generate-disclaimer | grep "nodetunes" # Nothing

I don't know if this applies to other packages, I just happened to notice that this one was missing.

What is the expected behavior? The license disclaimer for nodetunes should be included.

Please mention your node.js, yarn and operating system version.

$ node --version
v7.4.0
$ yarn --version
0.22.0

I'm running macOS Seirra 10.12.1 Beta (16B2553a).

milo73 commented 6 years ago

Still the case for the following packages: paths-js react-native-radio-buttons react-native-md5 react-native-hr

dontub commented 3 years ago

I have this issue with fork-awesome. This seems to happen when the license file has not one of the expected names (or no license file exists). Only file names matching (case-insensitive) license, license.*, unlicense, or unlicense.* are read: https://github.com/yarnpkg/yarn/blob/3119382885ea373d3c13d6a846de743eca8c914b/src/util/normalize-manifest/fix.js#L287

In case of fork-awesome the license file is named LICENSES.

dontub commented 3 years ago

Apart from adding additional file names to fix.js the following could solve the issue: