Yarn tries to create shims of shims during global package installation

yarnpkg / yarn

The 1.x line is frozen - features and bugfixes now happen on https://github.com/yarnpkg/berry

https://classic.yarnpkg.com

Other

41.4k stars 2.73k forks source link

Yarn tries to create shims of shims during global package installation #6958

Open ArcanoxDragon opened 5 years ago

ArcanoxDragon commented 5 years ago

Related to #6902

The update to @zkochan/cmd-shim@3.0.0 in yarn@1.13.0 revealed a dormant bug where Yarn calls cmd-shim on its own shims, creating shims of shims which do not function correctly in PowerShell. This issue mainly affects Windows, although creating shims of shims in Linux is probably not the greatest solution when the original shim could be used instead.

This issue is intended to track the underlying cause of this, and, eventually, a real fix that can replace the workaround in #6954 and allow proper PowerShell shims to be used.

tats-u commented 5 years ago

Thank you for creating this issue on behalf of me.

Additional info:

https://github.com/yarnpkg/yarn/blob/1af4c5f50c4c146a833c0c2b20d10be1f5a61803/src/cli/commands/global.js#L169-L171 camouflaged this issue before 1.12.3.
How to fix:
1. Make @zkochan/cmd-shim support shims of shims
2. Stop creating shims of shims (#6959)

ExE-Boss commented 5 years ago

i. Make @zkochan/cmd-shim support shims of shims

I don't think that's a real solution.

That's just a band-aid for a band-aid.

/cc @zkochan

tats-u commented 5 years ago

Shims mean symlinks made of shell scripts. Since symlink supports nested links, shims also must do. Or cmd-shim MUST CLARIFY that it doesn't.