search

yarnpkg / yarn

The 1.x line is frozen - features and bugfixes now happen on https://github.com/yarnpkg/berry
https://classic.yarnpkg.com
Other
41.45k stars 2.73k forks source link

yarn pkg duplicate logo in npm #779

Closed jdalton closed 7 years ago

jdalton commented 8 years ago

The package on npm has a duplicated logo: https://www.npmjs.com/package/yarn

ljharb commented 8 years ago

twice the kittehs, twice the funs

jdalton commented 8 years ago
Daniel15 commented 8 years ago

Looks like the first one is the "description" while the second one is the readme.

sindresorhus commented 8 years ago

Should be reported at https://github.com/npm/marky-markdown

Daniel15 commented 8 years ago

@sindresorhus - Why so? I think we just need to set a description in project.json so npm uses that rather than inferring it from the readme.

sindresorhus commented 8 years ago

@Daniel15 Because they should not infer an image as the description. That's clearly a bug.

Daniel15 commented 8 years ago

Ahh, is marky-markdown the library that's inferring the description based on the readme? Initially when I looked at it, it just looked like a Markdown parser, but maybe it also infers description based on readme and I missed that part 😄

sindresorhus commented 8 years ago

I believe so. It's what they use to cleanup and npmify the markdown. I've posted there about similar issues previously.

OmgImAlexis commented 7 years ago

Since the original issue is fixed this can be closed.