search

yarolegovich / DiscreteScrollView

A scrollable list of items that centers the current element and provides easy-to-use APIs for cool item animations.
5.78k stars 782 forks source link

Update to AndroidX #141

Closed bernaferrari closed 4 years ago

bernaferrari commented 6 years ago

Now released: https://developer.android.com/topic/libraries/support-library/androidx-overview

rayliverified commented 6 years ago

This would be fantastic. I can make a PR for this but will it be accepted?

bernaferrari commented 6 years ago

I think it is worth trying. The developer has been very busy lately, and I think it will be easier for him to click on "accept" than do it himself.

rayliverified commented 6 years ago

Let me look through my old commits. I think I updated one of his other libraries before so let me see if that was accepted.

rayliverified commented 6 years ago

143

rayliverified commented 6 years ago

Submitted a PR with updates.

mamatagelanee07 commented 5 years ago

@yarolegovich Can we please merge the pull request created by @searchy2? We are migrating to Android X and I just want to avoid add this library as a module in our app.

gneokleous commented 5 years ago

I have also created a PR with more recents updates around androidx and versions. https://github.com/yarolegovich/DiscreteScrollView/pull/179

Can you have a look @yarolegovich ?

gneokleous commented 5 years ago

FYI, if you have the following under your gradle.properties, then you shouldn't need the library to be using AndroidX artifacts. Jetifier should take care of it.

android.enableJetifier=true

Although, it would be nice to have the library actually migrated as jetifier seems to add a bit of overhead on build times.

yarolegovich commented 4 years ago

Resolved with #134 and v1.5.0