search

yaronn / ws.js

A WS-* client stack for node.js. Written in pure javascript!
http://webservices20.blogspot.com/
104 stars 64 forks source link

Create security.js #3

Closed ghost closed 10 years ago

ghost commented 10 years ago

There were issues with the security.js file extracting the certificate base64 hash from the pem file. It should look for the begin and end certificate keywords in the pem file to extract properly.

ghost commented 10 years ago

Awesome, thank you very much.

Will there be a delay in propagating the changes through npm install?

From: Yaron Naveh notifications@github.com<mailto:notifications@github.com> Reply-To: "yaronn/ws.js" reply@reply.github.com<mailto:reply@reply.github.com> Date: Friday, January 17, 2014 1:22 PM To: "yaronn/ws.js" ws.js@noreply.github.com<mailto:ws.js@noreply.github.com> Cc: Mesrob Kyurkchyan mkyurkchyan@axs.com<mailto:mkyurkchyan@axs.com> Subject: Re: [ws.js] Create security.js (#3)

Merged #3https://github.com/yaronn/ws.js/pull/3.

— Reply to this email directly or view it on GitHubhttps://github.com/yaronn/ws.js/pull/3.

ghost commented 10 years ago

Nevermind, I see the changes now. Thank yo again, appreciate the timely response.

From: Mesrob Kyurkchyan mkyurkchyan@axs.com<mailto:mkyurkchyan@axs.com> Date: Friday, January 17, 2014 1:45 PM To: "yaronn/ws.js" reply@reply.github.com<mailto:reply@reply.github.com>, "yaronn/ws.js" ws.js@noreply.github.com<mailto:ws.js@noreply.github.com> Subject: Re: [ws.js] Create security.js (#3)

Awesome, thank you very much.

Will there be a delay in propagating the changes through npm install?

From: Yaron Naveh notifications@github.com<mailto:notifications@github.com> Reply-To: "yaronn/ws.js" reply@reply.github.com<mailto:reply@reply.github.com> Date: Friday, January 17, 2014 1:22 PM To: "yaronn/ws.js" ws.js@noreply.github.com<mailto:ws.js@noreply.github.com> Cc: Mesrob Kyurkchyan mkyurkchyan@axs.com<mailto:mkyurkchyan@axs.com> Subject: Re: [ws.js] Create security.js (#3)

Merged #3https://github.com/yaronn/ws.js/pull/3.

— Reply to this email directly or view it on GitHubhttps://github.com/yaronn/ws.js/pull/3.

yaronn commented 10 years ago

Sure, enjoy :)