search

yaronn / ws.js

A WS-* client stack for node.js. Written in pure javascript!
http://webservices20.blogspot.com/
104 stars 64 forks source link

update formidable to use version 1.1.1 #36

Closed chrisgh1 closed 7 years ago

chrisgh1 commented 7 years ago

See following issue for discussion on error: Buffer.write(string, encoding, offset[, length]) is no longer supported https://github.com/yaronn/wcf.js/issues/16

maybe even would consider changing to ^1.1.1

santiperez commented 7 years ago

I also faced this issue. Is there any plan to accept this pull request and publish a new version of this module? Now Node version LTS is v6.11.4.

Thanks in advance.

Regards

TinoSM commented 7 years ago

For those waiting, meanwhile you can use npm-shrinkwrap to override the dependency to override the dependency, it's working fine on my end

"ws.js": { "version": "2.0.22", "dependencies": { "formidable": { "version": "1.1.1", "resolved": "..../formidable-1.1.1.tgz", "integrity": "sha1-lriIb3w8NQi5Mta9cMTTqI818ak=" } } }

yaronn commented 7 years ago

Hi, sorry for the delay, I've published ws.js@2.0.23 with this fix. Thanks for writing it!

santiperez commented 7 years ago

👍 Thanks @yaronn

Regards.